Skip to content

ref: Remove v9 checks for debug image provider #6454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2025
Merged

ref: Remove v9 checks for debug image provider #6454

merged 1 commit into from
Oct 20, 2025

Conversation

noahsmartin
Copy link
Contributor

@noahsmartin noahsmartin commented Oct 18, 2025 •
edited by github-actions bot
Loading

The V9 migration makes this class internal instead of public, which means it needs to be migrated to Swift to be part of the Swift dependency container. This removes the V9 checks and migrates it to Swift

#skip-changelog

Closes #6455

@github-actions github-actions bot mentioned this pull request Oct 18, 2025
Closed
@codecov Codecov
Copy link

codecov bot commented Oct 18, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.025%. Comparing base (1bf44b4) to head (1df3813).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
Sources/Sentry/SentryDebugImageProviderInternal.m 80.000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #6454       +/-   ##
=============================================
+ Coverage   87.023%   87.025%   +0.002%     
=============================================
  Files          450       451        +1     
  Lines        37806     37751       -55     
  Branches     17494     17474       -20     
=============================================
- Hits         32900     32853       -47     
+ Misses        4863      4855        -8     
  Partials        43        43
Files with missing lines Coverage Δ
SentryTestUtils/TestDebugImageProvider.swift 100.000% <ø> (+27.272%) ⬆️
Sources/Sentry/PrivateSentrySDKOnly.m 25.000% <ø> (+1.213%) ⬆️
...ces/Sentry/Profiling/SentryProfilerSerialization.m 86.219% <ø> (ø)
Sources/Sentry/SentryANRTrackingIntegration.m 97.041% <ø> (ø)
Sources/Sentry/SentryClient.m 99.327% <ø> (ø)
Sources/Sentry/SentryDependencyContainer.m 90.254% <ø> (ø)
Sources/Sentry/SentryTracer.m 97.712% <ø> (+0.163%) ⬆️
...s/Swift/SentryCrash/SentryDebugImageProvider.swift 100.000% <100.000%> (ø)
Sources/Sentry/SentryDebugImageProviderInternal.m 81.176% <80.000%> (ø)

... and 6 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bf44b4...1df3813. Read the comment docs.

@noahsmartin noahsmartin force-pushed the debugImageProviderV9 branch 4 times, most recently from a67e933 to 910fb79 Compare October 18, 2025 02:24
cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 18, 2025 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1225.48 ms 1265.78 ms 40.30 ms
Size 23.75 KiB 1021.49 KiB 997.74 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
13bc1aa 1244.04 ms 1262.89 ms 18.85 ms
2a07609 1207.79 ms 1233.77 ms 25.98 ms
59fc426 1240.49 ms 1256.94 ms 16.45 ms
8f2120f 1235.92 ms 1249.67 ms 13.75 ms
1a820a1 1217.79 ms 1260.34 ms 42.55 ms
d3e7aa6 1226.06 ms 1248.87 ms 22.81 ms
9264ee8 1233.15 ms 1250.02 ms 16.87 ms
a4c5ddc 1239.61 ms 1266.41 ms 26.80 ms
92a02b8 1220.89 ms 1249.27 ms 28.37 ms
c122943 1210.94 ms 1233.78 ms 22.84 ms

App size

Revision Plain With Sentry Diff
13bc1aa 23.75 KiB 908.40 KiB 884.65 KiB
2a07609 23.75 KiB 912.78 KiB 889.03 KiB
59fc426 23.75 KiB 920.64 KiB 896.89 KiB
8f2120f 23.75 KiB 941.78 KiB 918.03 KiB
1a820a1 23.75 KiB 994.82 KiB 971.07 KiB
d3e7aa6 23.75 KiB 913.16 KiB 889.41 KiB
9264ee8 23.75 KiB 913.09 KiB 889.34 KiB
a4c5ddc 23.75 KiB 977.30 KiB 953.55 KiB
92a02b8 23.75 KiB 913.17 KiB 889.42 KiB
c122943 23.74 KiB 926.65 KiB 902.90 KiB

Previous results on branch: debugImageProviderV9

Startup times

Revision Plain With Sentry Diff
39e4f97 1225.89 ms 1260.51 ms 34.62 ms
98bfcdb 1231.44 ms 1265.30 ms 33.86 ms

App size

Revision Plain With Sentry Diff
39e4f97 23.75 KiB 1021.48 KiB 997.73 KiB
98bfcdb 23.75 KiB 1021.48 KiB 997.73 KiB

philprime
philprime approved these changes Oct 20, 2025
View reviewed changes
Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one comment to double-check

@noahsmartin noahsmartin merged commit 3319d58 into main Oct 20, 2025
227 of 233 checks passed
@noahsmartin noahsmartin deleted the debugImageProviderV9 branch October 20, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@philprime philprime philprime approved these changes

@philipphofmann philipphofmann Awaiting requested review from philipphofmann philipphofmann is a code owner

@itaybre itaybre Awaiting requested review from itaybre itaybre is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ref: Remove v9 checks for debug image provider

2 participants

@noahsmartin @philprime